Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate proper CP calculation #447

Open
rossneilson opened this issue Aug 31, 2021 · 0 comments
Open

Integrate proper CP calculation #447

rossneilson opened this issue Aug 31, 2021 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@rossneilson
Copy link
Member

rossneilson commented Aug 31, 2021

Currently there is a basic clearing price calculation in the useBids hook for the fairsale page. However the solution taken from gnosis for this calculation in src/aqua/Price.ts should be more like what we really want. Some of the variables and data used in the function seem strange and Im not sure entirely what they are supposed to be from. Time will be needed to understand this, likely with reference to the final clearing price in the SC to adapt it to work in the UI properly.

@rossneilson rossneilson added this to the V1 Production milestone Aug 31, 2021
@rossneilson rossneilson added the enhancement New feature or request label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant