Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-KEM SIMD F* Extraction #269

Closed
Tracked by #236
, #296
...
franziskuskiefer opened this issue May 12, 2024 · 4 comments · Fixed by #308
Closed
Tracked by #236
, #296
...

ML-KEM SIMD F* Extraction #269

franziskuskiefer opened this issue May 12, 2024 · 4 comments · Fixed by #308
Assignees
@W95Psp @franziskuskiefer @mamonet

Comments

@franziskuskiefer
Copy link
Member

franziskuskiefer commented May 12, 2024 •
edited
Loading

This is blocking #301
@franziskuskiefer franziskuskiefer mentioned this issue May 12, 2024
Closed
5 tasks
@github-project-automation github-project-automation bot moved this to 🆕 New in libcrux May 12, 2024
@franziskuskiefer franziskuskiefer changed the title F* extraction of ML-KEM SIMD ML-KEM SIMD F* Extraction May 12, 2024
@franziskuskiefer
Copy link
Member Author

  • portable is extracting
  • avx2 is extracting
  • neon needs a dummy for the intrinsics to extract

@franziskuskiefer
Copy link
Member Author

Right now F* extraction is broken because of split_at_mut.

@franziskuskiefer franziskuskiefer mentioned this issue Jun 3, 2024
Merged
4 tasks
@mamonet
Copy link
Member

mamonet commented Jun 11, 2024 •
edited
Loading

I see that libcrux-ml-kem/src/vector.rs has dependencies in libcrux-intrinsics/src and this issue is about exracting the files in that directory, right?
Also, what kind of problem that split_at_mut causes and where I can look at?

@franziskuskiefer franziskuskiefer linked a pull request Jun 12, 2024 that will close this issue
Making ML-KEM Extract Again #308
Merged
@franziskuskiefer
Copy link
Member Author

This was fixed in #308 and #311

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in libcrux Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@W95Psp W95Psp

@franziskuskiefer franziskuskiefer

@mamonet mamonet

Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Making ML-KEM Extract Again cryspen/libcrux
3 participants
@W95Psp @franziskuskiefer @mamonet