Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin packages in requirements.txt #13

Open
achab opened this issue May 6, 2022 · 2 comments
Open

Pin packages in requirements.txt #13

achab opened this issue May 6, 2022 · 2 comments

Comments

@achab
Copy link

achab commented May 6, 2022

Hello team, thanks a lot for building amarna! Could you pin the packages on the file requirements.txt? There is a currently conflict on cairo-format with the current latest versions of cairo-lang and amarna. To reproduce it, on Python 3.7.2, you can run the following code:

python -m venv .venvtest
source .venvtest/bin/activate
pip install --upgrade pip
pip install cairo-lang

cairo-format # it works

pip install git+https://github.com/crytic/amarna.git@main

cairo-format # it fails
@fcasal
Copy link
Collaborator

fcasal commented May 9, 2022

Hi @achab, thanks for reporting this. The issue happens because cairo-lang uses an old version of lark (0.12). I've added versions to the requirements file (4015dff) but this does not fix the issue.

For now, the best solution is to use two virtual environments.
Another option that works (for now) is to first install amarna, and then cairo-lang.

@achab
Copy link
Author

achab commented May 9, 2022

Thanks a lot for the details, and thanks for the temporary solution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants