Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Students who have not logged in cannot have their attendances taken #389

Open
smartspot2 opened this issue Feb 9, 2023 · 0 comments · May be fixed by #393
Open

Students who have not logged in cannot have their attendances taken #389

smartspot2 opened this issue Feb 9, 2023 · 0 comments · May be fixed by #393
Assignees
Labels
bug Something isn't working sev3 High severity - Production system impaired

Comments

@smartspot2
Copy link
Member

If a user was added to a section but have not logged into scheduler, mentors cannot change the attendance for the student, because of a validation error when saving the object in the database through the serializer.

In particular, the following Django log is printed:

<Attendance:Failure> Could not record attendance for User <pk=24;[email protected]>, errors: {'student_name': [ErrorDetail(string='This field may not be blank.', code='blank')]}

Generally, this hasn't been an issue in the past, since student enroll themselves in sections, which requires them to have logged into scheduler. However, if a coordinator manually enrolls a student without having them login first, this creates a new user and student object without any associated name, causing this error when attempting to modify attendances.

@smartspot2 smartspot2 added bug Something isn't working sev3 High severity - Production system impaired labels Feb 9, 2023
@Veriny Veriny self-assigned this Feb 16, 2023
@Veriny Veriny linked a pull request Feb 17, 2023 that will close this issue
@smartspot2 smartspot2 linked a pull request Feb 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sev3 High severity - Production system impaired
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants