Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exit code needed in lst1_magic_event_coincidence.py #271

Open
joannaWojS opened this issue Nov 25, 2024 · 3 comments · May be fixed by #272
Open

New exit code needed in lst1_magic_event_coincidence.py #271

joannaWojS opened this issue Nov 25, 2024 · 3 comments · May be fixed by #272
Assignees

Comments

@joannaWojS
Copy link
Collaborator

In the script https://github.com/cta-observatory/magic-cta-pipe/blob/master/magicctapipe/scripts/lst1_magic/lst1_magic_event_coincidence.py , a new exit code is needed in the following section (line 526-528):

if event_data.empty:
logger.info("\nNo coincident events are found. Exiting...")
sys.exit()

When coincidences are not found, a file is not created. As a result, the script job_accounting.py, used during semi-automatic analysis, indicates that the files exist (because the list_failed file in logs is also not created), but the corresponding folder is empty. We encountered a similar issue at the stereo level some time ago. For data from the second half of 2021, job_accounting reported that 1424 files exist, but the folders are empty.

@Elisa-Visentin
Copy link
Collaborator

We could apply the same solution used for stereo reco. I have to check the already used exit codes...

@aleberti
Copy link
Collaborator

In the solution I implemented, you can add a new exit code quite easily, or reuse an already existing one, if it applies.

@Elisa-Visentin
Copy link
Collaborator

No worries! I will do that asap (it is in my 'extremely urgent' todo list...)

@jsitarek jsitarek linked a pull request Nov 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants