Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name table issues due to buggy FontForge based build #18

Open
Nigelw opened this issue Dec 30, 2021 · 3 comments
Open

name table issues due to buggy FontForge based build #18

Nigelw opened this issue Dec 30, 2021 · 3 comments
Assignees
Labels
B-minor This is a bug, but a minor one as it doesn't affect many users. bug Something isn't working
Milestone

Comments

@Nigelw
Copy link

Nigelw commented Dec 30, 2021

Love your work on this font. Heads up about a small issue. When I add the Style B ttf to my Mac using Font Book, I get an error on import:
Screen Shot 2021-12-31 at 10 10 24 AM

The other TTFs are fine, it's only this one which throws up a warning like this. I don't know much about font file structures so am not sure if this is worthy of a fix, but wanted to give a heads up.

@kenmcd
Copy link
Contributor

kenmcd commented Dec 30, 2021

All the fonts have name issues.
Surprised that is the only one flagged.
The Full Font Name is not the "full font name" in all the Regulars.
And all the Italics have the style-link set to Bold, which is probably what is causing Issue #15

@ctrlcctrlv ctrlcctrlv changed the title Error on import using Font Book: 'name' table structure name table issues due to buggy FontForge based build Dec 30, 2021
@ctrlcctrlv ctrlcctrlv self-assigned this Dec 30, 2021
@ctrlcctrlv ctrlcctrlv added B-minor This is a bug, but a minor one as it doesn't affect many users. bug Something isn't working labels Dec 30, 2021
@ctrlcctrlv ctrlcctrlv added this to the v1 milestone Dec 30, 2021
@ctrlcctrlv
Copy link
Owner

This font needs rebuilding from its masters, I know. I apologize for name table issues. This is one of my older fonts, and was the last one I built via a legacy, deprecated method (FontForge direct OTF creation).

It's worth mentioning that my fonts are best tested on GNU/Linux, which uses fontconfig, not whatever macOS or Windows does for that, and that's how this issue got into the releases.

I have made some progress towards moving this over to a UFO fontmake-based build…but that's not happening this week. I have a major release to make tomorrow, of FRB Amercan Cursive v2/FRB American Print v1. I'll figure out when I'm working on v1 of this font after that. This font is still technically not in v1, and this name issue is one big reason why.

@ctrlcctrlv
Copy link
Owner

The most recent release was not even a complete rebuild, because a complete rebuild is no longer possible without some serious work to recreate my old environment. You'd need an old patched FontForge, etc.

The last release just patched name and fixed a critical bug in GSUB:

https://github.com/ctrlcctrlv/TT2020/blob/master/build/version_0.2_patch.py

I guess another script like this could patch name again, but obviously what we really need is a way to do full builds again. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-minor This is a bug, but a minor one as it doesn't affect many users. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants