Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent utils.isPromise to crash when passing null #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prevent utils.isPromise to crash when passing null #61

wants to merge 1 commit into from

Conversation

Platane
Copy link

@Platane Platane commented Dec 21, 2018

hello,

Due to typeof null === 'object the isPromise test is crashing when passing null

Here a demo: https://codesandbox.io/s/3vyq17zy35

This PR fix that

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files           6        6           
  Lines         114      114           
  Branches       34       34           
=======================================
  Hits          104      104           
  Misses          8        8           
  Partials        2        2
Impacted Files Coverage Δ
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53afde8...f5eb416. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant