You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
React supports rendering of iterables and collections as childrens. react-tree-walker does not support this at this moment leading to unexpected results when using Iterables (e.g. List from immutable-js) as children. Subtrees that are rendered in react are might be skipped by the visitor.
Would you accept a PR w/ test that clears this issue @ctrlplusb? My version of the library is quite a bit different at this point (removed Preact stuff, breadth-first resolve rather than depth-first to allow for concurrency, added more strict element type checks etc), but I can try to make a PR as simple as possible for you.
Otherwise you can obviously just lift those sections on your own.
React supports rendering of iterables and collections as childrens.
react-tree-walker
does not support this at this moment leading to unexpected results when using Iterables (e.g.List
fromimmutable-js
) as children. Subtrees that are rendered in react are might be skipped by the visitor.I created a minimal example that shows the issue: https://codesandbox.io/s/o9kzlrql86
Here are some links from the original react discussion:
Original Issue
Original PR
Would be great to have this feature!
The text was updated successfully, but these errors were encountered: