Case sensitive #136
Case sensitive #136
Conversation
Formatting fix. More formatting changes, more consistency. Revert "Clear is now case-insensitive" This reverts commit ea8fe92. Proper fix this time.
| InventoryCleared = true | ||
| end | ||
| OtherPlayer:GetInventory():Clear() | ||
| InventoryCleared = true |
There was a problem hiding this comment.
This is not so good. The FindAndDoWithPlayer function actually calls the callback for the nearest name, it doesn't have to match.
Consider there are three players, Admin, Xoft and Xof. Now admin wants to cleat Xof's inventory, so he types /clear Xof. Just before sending the command, Xof disconnects, and Xoft's inventory gets cleared.
There was a problem hiding this comment.
But the likelihood of that happening is very small, and the usability benefit of being able to use partial names IMO outweights the possibility of doing the command to the wrong person.
There was a problem hiding this comment.
Perhaps show a confirmation message for critical commands like banning or clearing inventory?
are you sure? Press Y to confirm and delete the Inventory of <Full player name here>
There was a problem hiding this comment.
Better would be a delay where you could type /clear cancel to cancel the clearing. But IDK if that's the best solution.
|
Question: Do we want case-insensitive, or case-sensitive names? |
|
We want case insensitive names. |
|
That was answered before, but please do consider reconsidering: #761 Seeing as bearing himself voted no, opinions can change! :P |
|
@tigerw That's a different issue - the actual command. This is discussing the player names in the command. I still think that the command names themselves should probably be case-sensitive, in order that plugins can make up their own mind as to what to do with different capitalisations of commands. |
Made the commands case-insensitive and also autocomplete names. Fixes #135