Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Lua 5.3 #44

Open
qwertychouskie opened this issue Jun 19, 2019 · 1 comment
Open

Port to Lua 5.3 #44

qwertychouskie opened this issue Jun 19, 2019 · 1 comment

Comments

@qwertychouskie
Copy link
Member

Probably we can use add_definitions("-DLUA_COMPAT_5_1"), but it needs to be tested.

@v1993
Copy link
Member

v1993 commented Jun 19, 2019

It will simple make a lot of trouble, especially on Lua side.

Lua 5.1 is still used in production-ready applications and there's no real reason to get rid of it.

add_definitions is part of old CMake and should not be used anymore. To get -DLUA_COMPAT_5_1 working you must build Lua together with project, and, as I said, it will still very very likely produce troubles which aren't needed.

As a Lua guy I also have to say that cubosphere is built mostly in Lua 5.1 spirit (but it still performs pretty bad with recommended Lua ways in fact).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants