Types International transfers #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rogelioLpz
commented
Feb 21, 2022
•
rogelioLpz
commented
- closes Types International Transfers #206
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 992 1018 +26
=========================================
+ Hits 992 1018 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexviquez
requested changes
Mar 3, 2022
Comment on lines
+409
to
+416
| bank_number: str | ||
| account_number: str | ||
| account_country: Country | ||
| account_name: str | ||
| received_amount: int | ||
| received_currency: Currency | ||
| sent_amount: int | ||
| sent_currency: Currency |
There was a problem hiding this comment.
el campo de arch route no va a venir aquí? o no es necesario en este modelo
Comment on lines
+410
to
+412
| account_number: str | ||
| account_country: Country | ||
| account_name: str |
There was a problem hiding this comment.
objeto account con number, country, name
Comment on lines
+413
to
+415
| received_amount: int | ||
| received_currency: Currency | ||
| sent_amount: int |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.