-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Staff-Tuning tags in musicxml with sensible default #778
Comments
Thank you for this modification. Unfortunately it did not solve the problem, but by doing some manual tests, I realized that the problem was not caused by the unexpected
Although this correspond to standard guitar tuning, I don't know what would be the proper way to extract these informations from the m21 stream in case of non-standard tunings (like open D or others). Could we consider in a first step to add by default this standard tuning block as it will certainly cover a large majority of guitar tabs ? |
Reopening because of the problem noted above. Renaming issue. Might be a little while, since we're not fully supporting fretboards yet, though Luke Poeppel did some great work on this getting us ready to do so later. |
The question is whether we need a new
Seems easier to me to build on what we have -- read the musicxml file for a tuning, make a pitch array from the entries, if it matches one of the known fretboards, construct it, and drop it in the beginning of the part. Maybe a method in the tablature module Then in the export module, look for a FretBoard object @louisbigo any thoughts on directions here, or interest in making a more detailed proposal? |
music21 version
6.5.0
Problem summary
Hi,
It seems that the musicXML writer can produce mistakes when the m21 stream corresponds to a tablature.
The parsing seems ok (string/fret informations seem correctly stored in the m21 stream in articulations.FretIndication / articulations.StringIndication). However, the written musicXML file is invalid (as indicated when opening with MuseScore for example).
When looking into it, it seems that unexpected fret tags (more precisely
<fret>0</fret>
) have been added in place of technical indications (like hammer-on, pull-off) - see example below. I would not be suprised that multiple (and distinct) fret indications for one single note induces this invalidity.I guess that guitar specific technics such as hammer-on/pull-off are not yet implemented in m21. I think that simply omitting them (instead of replacing them by non-sense
<fret>0</fret>
) would produce a valid musicXML and might be a good option until that time.Thanks again for this fantastic tool !
Steps to reproduce
The musicXML page dedicated to tab (https://www.musicxml.com/tutorial/tablature/fret-and-string/) provides a simple test file (tab1.musicxml).
In tab1.musicxml we have (l.321) :
and in the analogue place of the file written by m21 (tab1-m21.musicxml) we have (l.288) :
The text was updated successfully, but these errors were encountered: