Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested change #10

Open
drcongo opened this issue Oct 11, 2016 · 1 comment
Open

Suggested change #10

drcongo opened this issue Oct 11, 2016 · 1 comment

Comments

@drcongo
Copy link

drcongo commented Oct 11, 2016

Just having a play with this and noticed an issue which should be relatively easy to work around, but thought I'd mention it here before offering a pull request in case there's a reason for the current design...

The docs suggest this as a way to mark that the index page has been visited @mark('index:visited', current_user.id) but if the user is not logged in then current_user doesn't have an id attribute.

Might it be better to pass just current_user and let flask-bitmapist decide whether to act on it if it finds an id attribute.

(As an aside, is it possible to make this work with an authenticated redis? I've been trying to pass the password in using the BITMAPIST_REDIS_URL but without any luck)

@frankV
Copy link
Member

frankV commented Oct 11, 2016

@drcongo thanks. That sounds like a good idea. If you want to issue a PR for it that would be great!

I've created a separate issue for the authenticated redis bug (#11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants