-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building is broken due to changed file structure in Colmap Repo #110
Comments
Thanks - we are very much aware of this issue but had to (and still need to) push back updating pixsfm because COLMAP is currently going through a major update and we first need to update and test other dependencies. For now please use pinned versions/commits (see these changes). |
Is this relevant again? Colmap 3.9 was released and Hierarchical-Localization was also updated to pycolmap 0.6.0 |
I've updated most of the header includes and renames. Hopefully I can finish the rest tomorrow: |
Yes I haven't yet found the time to update pixsfm to 3.9. Thanks a lot for working on this, feel free to send a PR and I'll review it! |
how is it going? This repo is included in nerfstudio docker... |
Issue:
Building this project with the current Colmap repo is not possible, due to some recent changes in the file structure of colmap, which causes the include paths to not resolve anymore, see: colmap/colmap@3c38248 and colmap/colmap@91068ea
Also, alignment.h was deleted in the Colmap repository, which this project relies on (Not too sure about if it actually is needed, but it's included in some headers), see: colmap/colmap@03af239
The same changes break pycolmap and pyceres atm, see: colmap/pycolmap#153 and cvg/pyceres#16 . PR to fix these changes exist there already, but are not integrated yet.
Solution:
I updated the headers in a new PR: #111
As a temporary workaround, you can install the project from my fork, which should work: https://github.com/ChristopherRemde/pixel-perfect-sfm
However, before installing pixel-perfect-sfm you need to build pyceres and pycolmap manually yourselfes for the time being, with these fixes manually patched in by yourself: cvg/pyceres#17 & colmap/pycolmap#152
Then, after cloning the fork of pixel-perfect-sfm, you need to remove the first two lines from the requirements.txt:
and then build normally, like in the instructions.
The text was updated successfully, but these errors were encountered: