Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema handling for non-CWRC-Writer documents #37

Open
ilovan opened this issue Nov 14, 2018 · 5 comments
Open

Schema handling for non-CWRC-Writer documents #37

ilovan opened this issue Nov 14, 2018 · 5 comments
Assignees

Comments

@ilovan
Copy link
Contributor

ilovan commented Nov 14, 2018

Problem occurred when trying to test an EpiDoc document (ISicily)

Steps to Reproduce (for bugs)

  1. a. Loaded a new document from user JonPrag (Jonathan) (iSicily/inscriptions)
    or
    b. Uploaded an inscription file that Jonathan sent
    or
    c. Pasted an EpiDoc xml into the text box
  2. Validated the resulting file
    Result: The file validates against the CWRC Tei schema instead of the schema declared in the opened/uploaded/pasted file (Epidoc)
  3. Went to settings to check schema association
    Result: The schema dropdown shows "CWRC TEI lite" as the schema
  4. Clicked on "Add new schema" and inputed the label and URL for the EpiDoc schema; hit "Add"
    Result: EpiDoc Schema is added to the dropdown list
  5. Selected the schema from the schema dropdown and hit "Apply"
    Result:
    image
    Also, the document would not save anymore (hitting on save doesn't do anything anymore
  6. Go back to "load document"
  7. Selected another inscription from Jonathan's repository
  8. Hit "Validate"
    Result: File validates against the right schema.
    Check of schema in the settings schema dropdown shows EpiDoc as the selected schema.
  9. Go back to "load document" and randomly load another document that is not an inscription
  10. Go back to "load document" and load another inscription from JonPrag/ISicily /inscriptions
    Result: Document loads, but
    image
  11. Hit "Validate"
    Result: File validates against the right schema, which is also selected in the settings schema dropdown

Expected Behaviour

Ideally, upon loading a document associated with an "external" schema, the user shouldn't have to add it to settings dropdown (this should be done automatically by CWRC Writer and the validation should be run against the schema declared in the document, not against the CWRC TEI lite schema

@ajmacdonald
Copy link
Collaborator

The error loading schema message is because we're trying to load an HTTP resource from a HTTPS origin. We need some sort of proxy to get around that.

@ajmacdonald
Copy link
Collaborator

Saving gets broken because it's looking for non-existent mappings. I'll need to look into that further.

@ajmacdonald
Copy link
Collaborator

Even if the schema were located at an HTTPS URL, we'd still get a CORS error. So, we need a proxy in any case. I'm fairly certain this issue has been raised before.

@ajmacdonald
Copy link
Collaborator

@ilovan ilovan added the Epic label Nov 15, 2018
@ajmacdonald
Copy link
Collaborator

Related commit. Handling for entity buttons in non-cwrc-writer documents:
cwrc/CWRC-WriterBase@fa4949d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants