Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a new file does not work on cwrc-writer.cwrc.ca #89

Open
ilovan opened this issue Feb 1, 2021 · 1 comment
Open

Saving a new file does not work on cwrc-writer.cwrc.ca #89

ilovan opened this issue Feb 1, 2021 · 1 comment
Assignees

Comments

@ilovan
Copy link
Contributor

ilovan commented Feb 1, 2021

No description provided.

@ilovan
Copy link
Contributor Author

ilovan commented Jun 17, 2021

Full slack discussion from https://cwrcteam.slack.com/archives/C9YR1Q99N/p1621893887052600:

Luciano Frizzera 23 days ago
There is also an assumption of a master branch when loading a file. So, the new file saved under main will not be listed on GitWriter. If I change the load dialog to list main , than we will lose access to all the repos that have master as default branch.

Luciano Frizzera 23 days ago
So, the right solution. 1. switch to main as default branch (quick and easy) and 2. allow users to choose the branch when saving and loading (this may take time - a week maybe).

Luciano Frizzera 23 days ago
The palliative solution: rename the default branch to master at the time of repo’s creation. GitHub says that this is fast, but can take a few minutes (maybe in the case of the branch having a large number of files).

Luciano Frizzera 23 days ago
So, did the palliative solution and pushed the code.

Luciano Frizzera 23 days ago
However, since this repo (Git-dialogs) wasn’t not merge to production since Dec 2020, I’m afraid it might break the main repo (write-base).

Luciano Frizzera 23 days ago
This has to do with jquery version.

susan_brown 23 days ago
So don’t update right now! Fascinating backstory.
👍
1

Luciano Frizzera 23 days ago
I will check is I can fixed an issue preventing me to update dev-cwrc-write. If I can solve it today, I will let you know.

Luciano Frizzera 23 days ago
The palliative solution for this case will be working on dev.

Luciano Frizzera 23 days ago
Together with the new validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants