Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing of bibcits not working as it ought - standalone and embedded versions #456

Open
2 tasks
SusanBrown opened this issue Oct 30, 2016 · 1 comment
Open
2 tasks
Assignees

Comments

@SusanBrown
Copy link

SusanBrown commented Oct 30, 2016

@ajmacdonald

  • you can apparently (sometimes, not reliably) edit the tag from the edit panel by right clicking the icon or between the icon and the parentheses, but the changes entered via the edit tag dialog do not always get saved, although they sometimes do
  • if you try to edit a citation entity by clicking on the "edit tag" button in the dialog, you get an error message {replicated this in the standalone version}
    image
@jefferya
Copy link
Contributor

@SusanBrown

Regarding the second point, the CWRC Dialogs can't edit MODS because of how they where written. To facilitate editing the full range on MODS elements, the CWRC-Dialogs would need to be completely rewritten, at least the title dialog. The current title dialog doesn't capture the wide range of MODS elements (only those elements present on the "create/new" form) and if I remember correctly would delete any MODS element outside the small subset of supported elements.

Ideally, this goes back to an approach discussed three years ago, trying to create Javascript popups from the forms built using this module: https://github.com/Islandora/islandora_xml_forms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants