Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale entity code to avoid confusion #31

Open
jefferya opened this issue May 11, 2018 · 5 comments
Open

Remove stale entity code to avoid confusion #31

jefferya opened this issue May 11, 2018 · 5 comments

Comments

@jefferya
Copy link
Collaborator

Two modules contain code to edit/search entities. The stale, deprecated code should be removed with any useful features ported to the new (e.g., error handling). Note: this could be done in conjuction with the TEI entities work.

Review:
https://github.com/cwrc/cwrc_entities

Depreciate (and pull out useful bits):
https://github.com/cwrc/Islandora-CWRC-Writer/blob/master/includes/entity.inc

@SusanBrown
Copy link

@ajmacdonald Is this straight-forward and if so can we assign this to you?

@ajmacdonald
Copy link
Collaborator

@SusanBrown this code is in PHP which isn't something I'm very familiar with

@ilovan
Copy link
Contributor

ilovan commented Jun 5, 2018

@ajmacdonald , could you do it though if you checked in with @jefferya along the way?

@ajmacdonald
Copy link
Collaborator

@ilovan as a last resort I could try it but I would warn that this is outside of my expertise in two areas: Drupal and PHP

@SusanBrown
Copy link

@nikathone We think you could undertake this. Please consult as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants