Minor bug fixes #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to include <cstring> to avoid compile error due to the use of strncopy.
NavierStokesModel now takes in BaseFlow objects rather than Flux objects. Also, the pitch and plunge examples now create their own output directories (as the Oseen example already did).
…ctory names rather than extensions.
…to zero. Previously, vorticity had been set to zero, but boundary forces and fluxes were not specified. This meant the associated arrays were full of random data, leading to nondeterministic and incorrect behavior.
Was previously entered as a long decimal. Now uses arctan, as is done in other files.
|
Fixed a few minor bugs. The repository is now in better shape for new users, who would expect, at minimum, to be able to: (1) compile the code, (2) run the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some bugs that arose when trying to compile the IBPM code and examples on a Windows 10 machine. With new fixes, code and examples compile/execute successfully.