You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Since httpClient is currently an internal field it makes unit testing and expanding the Client class significantly harder and involves vague techniques (e. g. to make possible HttpClient substitution with a mocked one I've changed RootNamespace property of my test project to Conjur).
Describe the solution you would like
Make httpClient field either protected, public or assignable from outside in some other way (e.g. parameter of constructor).
Additional context
Mocking HttpClient is essential in unit testing since we need predictable responses. In expanding of the Client class, accessing to an HttpClient instance also plays major role.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Since
httpClient
is currently an internal field it makes unit testing and expanding theClient
class significantly harder and involves vague techniques (e. g. to make possibleHttpClient
substitution with a mocked one I've changedRootNamespace
property of my test project toConjur
).Describe the solution you would like
Make
httpClient
field either protected, public or assignable from outside in some other way (e.g. parameter of constructor).Additional context
Mocking
HttpClient
is essential in unit testing since we need predictable responses. In expanding of theClient
class, accessing to anHttpClient
instance also plays major role.The text was updated successfully, but these errors were encountered: