Bump version to 1.28.1 #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YZ775
reviewed
May 22, 2024
There was a problem hiding this comment.
Could you add these changes in CHANGELOG?
- change CKE to proceed rebooting immediately after draining of node is completed #707
- change backoff algorithm to exponential backoff #726
These are not back-ported to 1.27.11, but merged into main as a new feature.
|
Thank you! 🙏 |
YZ775
requested changes
May 22, 2024
| ### Added | ||
|
|
||
| - Take in updates of CKE 1.27.11. See [CKE 1.27.11](https://github.com/cybozu-go/cke/blob/v1.27.11/CHANGELOG.md#12711). | ||
| - change CKE to proceed rebooting immediately after draining of node is completed [#707](https://github.com/cybozu-go/cke/pull/707) |
There was a problem hiding this comment.
Sorry, I think L21,L22 should be placed on ## Changed section. Could you fix this?
There was a problem hiding this comment.
Sorry, I cannot see the changes.
Could you check again please?
There was a problem hiding this comment.
Sorry, I pushed again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.