Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set systemReserved and plus #2746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set systemReserved and plus #2746

wants to merge 2 commits into from

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented Dec 11, 2024

No description provided.

@takara9 takara9 self-assigned this Dec 11, 2024
Comment on lines +216 to +217
#evictionHard:
# memory.available: "0%"
Copy link
Contributor

@morimoto-cybozu morimoto-cybozu Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to update evictionHard.
The kubelet has the default configuration of memory.available<100Mi. This seems reasonable. Moreover, setting memory.available alone cancels other default configurations such as nodefs.available<10%.

BTW, what do you want to mean by memory.available: "0%"?

  1. The hard eviction will never occur.
  2. Pods will be evicted indeed, but only when they use >100% of available memory. (I'm not sure whether they can use >100%.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete unnecessary lines.

If you think that this configuration should become necessary in the near future but we have some reason to exclude it now, please leave a description as a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plsease see evictionHard in the table at this URL.
https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/#kubelet-config-k8s-io-v1beta1-KubeletConfiguration

"0%" is to explicitly disable evition.
It need to prevent pod evict from low memory node.
if evictionHard.memory is not set, when memory fewer than low, Pod moved other node.

It would be fine to remove the settings and re-set them based on the results of the experiment.

Comment on lines +214 to +215
enforceNodeAllocatable:
- pods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems the same as the default.
If you don't change enforceNodeAllocatable, evictionHard, nor systemReserved, this PR will change nothing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be explicitly set, as there were many comments in the meeting that people did not understand the default values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants