-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set systemReserved and plus #2746
base: main
Are you sure you want to change the base?
Conversation
7ae491b
to
0c60869
Compare
#evictionHard: | ||
# memory.available: "0%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to update evictionHard
.
The kubelet has the default configuration of memory.available<100Mi
. This seems reasonable. Moreover, setting memory.available
alone cancels other default configurations such as nodefs.available<10%
.
BTW, what do you want to mean by memory.available: "0%"
?
- The hard eviction will never occur.
- Pods will be evicted indeed, but only when they use >100% of available memory. (I'm not sure whether they can use >100%.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete unnecessary lines.
If you think that this configuration should become necessary in the near future but we have some reason to exclude it now, please leave a description as a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plsease see evictionHard in the table at this URL.
https://kubernetes.io/docs/reference/config-api/kubelet-config.v1beta1/#kubelet-config-k8s-io-v1beta1-KubeletConfiguration
"0%" is to explicitly disable evition.
It need to prevent pod evict from low memory node.
if evictionHard.memory is not set, when memory fewer than low, Pod moved other node.
It would be fine to remove the settings and re-set them based on the results of the experiment.
enforceNodeAllocatable: | ||
- pods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems the same as the default.
If you don't change enforceNodeAllocatable
, evictionHard
, nor systemReserved
, this PR will change nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be explicitly set, as there were many comments in the meeting that people did not understand the default values.
No description provided.