You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wouldn't it be better to split two targets onto two different drivers?
I don't think that amount of if checks (we have now in the code) is better than possible code duplication.
sessionStorage and localStorage have different level of support among browsers.
So library can work with one and not work with another. Changing driver factory implies this more than
changing key.
"Controlling argument" is kinda of bad programming style.
CycleJS driver is about side effect type. LocalStorage and SessionStorage are two different targets. They may have considerably different implementation, performance characteristics, etc.
Two drivers better describe what goes on in reality.
The text was updated successfully, but these errors were encountered:
Wouldn't it be better to split two targets onto two different drivers?
if
checks (we have now in the code) is better than possible code duplication.sessionStorage
andlocalStorage
have different level of support among browsers.So library can work with one and not work with another. Changing driver factory implies this more than
changing key.
Two drivers better describe what goes on in reality.
The text was updated successfully, but these errors were encountered: