Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation for string templates on "External Triggers" page #6051

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Diquan-BOM
Copy link
Contributor

@Diquan-BOM Diquan-BOM commented Apr 4, 2024

add s after string templates in documentation
closes #6050
tests im assuming arent needed for change, since its only a 2 character change to documentation.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

add s after string templates in documentation
@Diquan-BOM
Copy link
Contributor Author

Diquan-BOM commented Apr 4, 2024

some things i wasnt too certain of so i left them unchecked, in case they are relevant. I also added my name as a code contributor since this is my first pull request on this repository.

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Diquan-BOM

@oliver-sanders oliver-sanders added this to the cylc-8.3.0 milestone Apr 4, 2024
@oliver-sanders oliver-sanders added the doc Documentation label Apr 4, 2024
@oliver-sanders oliver-sanders merged commit 5b672e3 into cylc:master Apr 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing s after string templates in documentation
2 participants