Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db exception detail #6470

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Db exception detail #6470

merged 4 commits into from
Nov 11, 2024

Conversation

psa
Copy link
Contributor

@psa psa commented Nov 11, 2024

Make it easier to debug write attempt failures by logging the error from SQLite.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
    • Simple text change in error logging
  • Changelog entry included if this is a change that can affect users
    • Trivial usability improvement
  • Docs not needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
Copy link
Member

(closing and re-opening to sort the tests out)

@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Nov 11, 2024
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested as working.

@psa, did you get to the bottom of the write error?

cylc/flow/rundb.py Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders merged commit 4686f5f into cylc:master Nov 11, 2024
28 checks passed
@psa
Copy link
Contributor Author

psa commented Nov 11, 2024

LGTM, tested as working.

@psa, did you get to the bottom of the write error?

We're still working on it, it only shows up every month or so, so it's been a bit of a pain to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants