-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUESTION: Move on from CoffeeScript? #56
Comments
Hi @pedrosanta , And porting to ES6 or Typescript is also a good change to refactoring some old/abandoned code, and I'm learning ES6 too. 😉 Cheers, let's do this. 🤖 |
Great @cyrilis! So, if you don't have a strong opinion between those two, I would lean to migrate to ES6 at the moment (which will already allow us to upgrade the code/syntax by a lot) – and if we feel the need later, upgrade to TypeScript. Sounds fair? |
Yeah, sounds good! 👍
Pedro Machado Santa <[email protected]>于2018年3月26日 周一下午6:20写道:
… Great @cyrilis <https://github.com/cyrilis>!
So, if you don't have a strong opinion between those two, I would lean to *migrate
to ES6 at the moment* (which will already allow us to upgrade the
code/syntax by a lot) – and if we feel the need later, upgrade to
TypeScript.
Sounds fair?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABv8zTF5mqPbxH7iVDBGZngqH3yQaPbZks5tiMDsgaJpZM4S5Q2y>
.
|
+1 for ES6. It would also make it easier for people like me to contribute more frequently to the repo. |
I'll just leave this here in case you hadn't seen it: https://github.com/decaffeinate/decaffeinate |
@cyrilis i just converted it to typescript, without reading code first. 😕 Edit: type definitions might be helpfull with current build |
👍 for typescript |
On my side, I'm definitely in favor of TypeScript. However moving first to ES6 could be a first step before going on TS. |
@emagnier it took less than hour to convert this to typescript, with help of decaffeinate, and few simple types, since ES6 is still valid TypeScript you can cut some corners and disable some of default checks. check commits from my fork, gcoda/epub-gen. |
Hi all,
So something has been crossing my mind over and over... at the time the work on this lib began (2015) the JS ecosystem was quite different from nowadays, and within that context I understand the benefits that CoffeeScript brought, namely, class syntax, arrow functions of sorts, and many others.
But given the latest advances of JS, namely with ES6, Promises and all, and I ponder if it wasn't beneficial from a maintenance standpoint to consider to migrate to ES6 or TypeScript?
I focus on the maintenance standpoint for two main reasons:
Personally, I find the usage of CoffeeScript at this point to be more cumbersome (and make the code harder to read) than not, and between the two proposals above I'm still leaning to ES6 at this point, basically for the sake of simplicity. (We can always move on to TypeScript if we strongly feel that need later on.)
Thoughts? @cyrilis?
The text was updated successfully, but these errors were encountered: