Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulating the color library inside marker #9

Open
cyucelen opened this issue Oct 6, 2019 · 1 comment
Open

Encapsulating the color library inside marker #9

cyucelen opened this issue Oct 6, 2019 · 1 comment
Labels
enhancement New feature or request Hacktoberfest Festival of open source community! help wanted Extra attention is needed

Comments

@cyucelen
Copy link
Owner

cyucelen commented Oct 6, 2019

Marker depends on fatih/color library to colorizing strings for terminal output. Encapsulating the colorizing behavior inside marker library to prevent multiple imports from user side can be beneficial.
I want to discuss the implementation details of this encapsulation and if its overkill and comes with restrictions along with it or not.
@cyucelen cyucelen added enhancement New feature or request help wanted Extra attention is needed Hacktoberfest Festival of open source community! labels Oct 6, 2019
@cyucelen
Copy link
Owner Author

cyucelen commented Nov 2, 2019

This will be probably a breaking change. fatih/color already archived maybe we can just include the whole project to our?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest Festival of open source community! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyucelen