Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify warning #220

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Modify warning #220

merged 3 commits into from
Jun 12, 2024

Conversation

ieivanov
Copy link
Contributor

This PR cleans up the converter logging:

  • Only one warning is issued per P-T-C, rather than issuing a warning for every P-T-C-Z
  • FOV name is included in the warning message
  • Logger console output is redirected to tqdm.write() for cleaner output - see before and after images

Before:
before

After:
after

@ieivanov ieivanov requested review from JoOkuma and ziw-liu May 23, 2024 22:51
@ziw-liu
Copy link
Collaborator

ziw-liu commented Jun 12, 2024

The CI failure is a breaking change in ome-zarr-py (likely in v0.9.0).

ziw-liu
ziw-liu approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@ziw-liu ziw-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ziw-liu ziw-liu added enhancement New feature or request μManager Micro-Manager files and metadata labels Jun 12, 2024
@ieivanov
Copy link
Contributor Author

The CI failure is a breaking change in ome-zarr-py (likely in v0.9.0).

Thank you!!

@ieivanov ieivanov merged commit a623faa into unified-api Jun 12, 2024
7 checks passed
@ieivanov ieivanov deleted the modify_warning branch June 12, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziw-liu ziw-liu ziw-liu approved these changes

@JoOkuma JoOkuma Awaiting requested review from JoOkuma

Assignees
No one assigned
Labels
enhancement New feature or request μManager Micro-Manager files and metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ieivanov @ziw-liu