-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP of napari viewer #30
base: main
Are you sure you want to change the base?
Conversation
|
||
if lf_data is not None and ls_data is not None: | ||
# update data | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be slightly faster to check the key with something like:
if LF_LAYER_NAME not in viewer.layers:
viewer.add_image(...)
else:
...
if LS_LAYER_NAME not in viewer.layers:
...
else:
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yield (lf_data, ls_data) | ||
|
||
if time.time() - t_start < 60: | ||
if _verbose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be logging.debug
instead?
Linking micro-manager/NDStorage#110 |
In today's copylot meeting, @AhmetCanSolak showed copylot's Viewer which is faster and less laggy than napari viewer. This can be found here and imported very similarly to napari's. Should we also try this ? |
I don't anticipate |
fixes #12
Intended usage
python viewer.py /path/to/dataset
, for example,python .\viewer.py "Q:\Ivan\testing\mantis_acquisition_test_12"
On the terminal you'll see messages such as
That's OK, that is currently the expected behavior. When viewing the data, you may also occasionally see a "seek of closed file error" (or something like that) - that's OK too, it doesn't cause any problems.
I've tested this viewer with the demo acquisition, and it seems to run well, without disturbing the ongoing acquisition. Will also test on the mantis.
TODO:
subprocess.Popen(["python", "viewer.py", "/path/to/dataset"])