Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socketed Gems create false negative (on pants) #190

Open
dominicnunez opened this issue Feb 26, 2024 · 5 comments
Open

Socketed Gems create false negative (on pants) #190

dominicnunez opened this issue Feb 26, 2024 · 5 comments

Comments

@dominicnunez
Copy link

From the images you can see that if I socket gems into the pants, the filter indicates these pants are not good but fine with no socketed gems. Not a big deal but kind of annoying. I haven't seen this happen with anything but pants.

image
image

@chrisoro
Copy link
Contributor

How does your general.Armor filter look like?

@dominicnunez
Copy link
Author

dominicnunez commented Feb 27, 2024

image

@aeon0
Copy link
Contributor

aeon0 commented Feb 28, 2024

Its a known issue. What happens is that the socket is not detected and d4lf reads the affix as "damage reduction from close enemies from close enemies maximum life maximum life". It probably then matched the affix against maximum life instead of damage reduction and since you already have maximum life as an affix on the item its ignored.

I am not planning to work around this for now. The focus of the lootfilter is filter new loot. If you already put gems into an item I assume you want the item and know the item.

I will keep the issue open, because I do understand that its a bit annoying to see the red color on an actually really good item you have.

@epicwalrus10
Copy link

Hi! I'm wondering what the discord link is for the loot filter discord. I'm having a hard time with the loot filter. Or if anyone has any examples or even a template of what their .yaml file is like.

@chrisoro
Copy link
Contributor

it's linked in the readme. readme also tells you how to configure it. :)

https://discord.gg/YyzaPhAN6T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants