Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxroll chest import issue #398

Open
TheOne320 opened this issue Oct 20, 2024 · 6 comments
Open

Maxroll chest import issue #398

TheOne320 opened this issue Oct 20, 2024 · 6 comments

Comments

@TheOne320
Copy link

TheOne320 commented Oct 20, 2024

Version 5.8.10

When importing this build:

https://maxroll.gg/d4/planner/1p8k0pan#9

The chest is this:
image
But the profile after importing is this:

Affixes:
- ChestArmor:
    affixPool:
    - count:
      - {name: maximum_life}
      - {name: dexterity}
      - {name: armor}
      minCount: 2
      minGreaterAffixCount: 0
    itemType: [chest armor]
    minPower: 100

The chest should not have armour.

@chrisoro
Copy link
Contributor

chrisoro commented Oct 22, 2024

I dont see that chest in the link you provided

@TheOne320
Copy link
Author

I dont see that chest in the link you provided

That is because all the builds got changed yesterday and that chest is now not there anymore. Does the screenshot not help? The problem should still be fixed.

@chrisoro
Copy link
Contributor

The screenshot doesn't help since I need to see the content of the maxroll api for that build :(
I believe you that it was a bug, I just can't fixit without an example :(

@TheOne320
Copy link
Author

Okay, I will update it when I see it happen again.

@TheOne320
Copy link
Author

@chrisoro
Okay, so I rebuild the chest in a custom profile in the planner and imported it and the bug still exists. This profile should not change as I created it:

https://maxroll.gg/d4/planner/nqi6a0hn

@chrisoro
Copy link
Contributor

Thank you that helped a lot. I have it fixed now. Will be published as 5.8.11 after we are finished with doing some organizational changes to the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants