-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin Story #1
Comments
Speaking SharedUserID, it should have a separate tab and sort apps that have same SharedUserID |
Not sure how that would look UI wise, so it's 3 tabs?
|
On the Apps tab where all apps are listed, a label (similar to the ones used in SD Maid) indicating SharedUserID should be fine. Clicking on the label should list all the other apps in a small pop-up window that have the same SharedUserID. Clicking on the app (or anywhere else in the app row) should list every single permission requested by the app, with filters to see the ones allowed and those that are disallowed. I'm not sure if a separate tab is required. |
Having a tabs can sort it. for your suggestion
Why not both? |
I will admit I don't fully understand the SharedUserID feature. Is this something that many apps use? As far as I understood, this SharedUserID is limited to apps from the same developer, isn't it? If not many apps have this, then a separate tab may be unnecessary to keep the UI simple and clean. |
You got a point, shared id is rare can can mostly found used in system apps. |
Lol, do you mean "Could you also add a dark theme, please?" 🤔 It will pick a theme based on your system setting. Colors are defined here, feel free to tweak them, there is a tool to generate themes here: |
Edited my last comment and users can import their own theme? |
No this is a code change. You and @TheMysticS could contribute more than just discussions if you want 🙂. The generated files contain a color set which can replace the current one: The purple color scheme is not super nice, it's just the default of another project of mine (https://github.com/d4rken/android-starter-v4). |
Automatic builds are now working: Time for 😴 |
Good night |
Okay! |
That was superfast. 😍😍 The Permissions tab can be simplified, by listing them using the same name as in System Settings: This list, however, will include all those permissions that appear under Special Access, as well as Permissions Manager. Descriptions can be shown once an item is clicked or as an expandable item in the form of an 'i' button on the main screen against each permission. Anyways, we can discuss these after a good night's sleep. I'll go through your links and help you in whatever way I can. Thanks very much. Goodnight. |
Under Android System Settings, we only see about 30 permissions (all 3 places put together). The permissions tab in this app has literally well over a hundred permissions, and many of these towards the end haven't been granted to any app. Are these other permissions not modifiable? If so, can we have some filters for this section: 🔲 All Apps 🔲 Include non-modifiable permissions |
I have proposed just one change to the primary colour: from the existing one to #002121. Is it possible to make these changes within the app and see how it looks? |
Im gonna make a pull request for it |
Oh wait i think i can build it, hold on |
Aaaand it throws me an error |
Hey @d4rken how do i gonna fix this error |
What did you do? Modify the apk? |
I have prepared a layout of how the screen will look like when someone clicks on an app to see all the permissions: Do you like it? The items may be reclassified to a different risk category if the current classification is not correct. Each of the permission above is actually a direct link to System Settings for that app, so user can modify the permission, as necessary. |
When opening the project in Android Studio, set the buildVariant to "debug", then you should be able to modify the app and install it. In the
Nice mockup! Some thoughts:
Many just belong to the |
Uh, i did the build using this |
We need the identifiers, e.g. what SD Maid or other apps display for an app installed from that store. |
Nothing. A label will only be shown for apps that do not come from any of the above sources. |
There is only one identifier for the Galaxy Store, isn't it? By identifier, do you mean package name? |
I will just do a Google search and list the package names of the known official stores. |
Here it is (based on Google search): Samsung: com.sec.android.app.samsungapps Huawei: com.huawei.appmarket From what I read, I think Oppo & Vivo use Huawei's App Gallery as an alternative to Google Play Store. They don't have a store of their own. So essentially there are only two official App Stores in addition to Google Play Store. Apps installed from any of these Stores will not have any label for that. Only apps that have been installed using other apps will have a label. |
Can you create a new ticket to track this as new feature? |
I have already done that as a new feature request for SD Maid. Do you want me to open another one? |
Yes. You can keep the information in one ticket, and link to it in the other ticket. |
Okay. We can continue discussion of this particular feature here: |
|
I'm not sure what your plans for the Permissions tab is. For those 30 or so permissions that user can control via System Settings: Will you be displaying those with the same names as they appear in System Settings? And club all the others under Additional Permissions? If you intend keeping the Permissions tab as it is now, then can you implement a Filter Bar like this: Here, the icons will all be of the same colour (green is fine). Tapping on any of them will list all apps which have that permission enabled. This bar will be scrollable horizontally to accomodate the remaining permissions not visible currently. |
Please open new issue tickets for separate ideas (don't forget to reference the version you are testing on). I'm getting confused by this one 😆 |
By @TheMysticS from d4rken-org/sdmaid#5609
The text was updated successfully, but these errors were encountered: