FTP file browser does not descend into directories

[rhaleblian]

Immediately apparent when browsing asimov.net, since games are in genre directories.

Taking a look at it.

[rhaleblian]

Not caching for directories works fine. File requests still hit the cache. Makes for simpler code as well.

Two side notes:

1. the single file in cache/ is named ftp.(null), which seemed odd. But probably irrelevant if you're not caching dirs.
2. selected files drop next to cache/, not in it. Maybe that's by design.

[rhaleblian]

See #3 .

[dabonetn]

Ok, so I've compiled from your source and it still won't browse directories.

Did you test your code yet?

[rhaleblian]

Worked for me back in the day. Let's see what my mileage is these days.

[rhaleblian]

Still works. I checked that the existence of file cache/ftp.(null) from a previous session running master branch doesn't mess things up; it didn't for me but if you try again you might want to delete ftp.(null) first.

One error still persists -- the browser initially drops into the first subdirectory, 'action'. This error is in master as well.

Note: i had to make the dir cache in ftp myself, but you knew that, because if it's missing you'll get "Failure. Press any key!" in the browser.

[rhaleblian]

The binary I get, and the config:

https://drive.google.com/drive/folders/1gwYEt2PqrmX2Qt6myNA0-4M2Lg7SwWZm?usp=sharing

[rhaleblian]

Oh, the browser opens where you last downloaded a file, so the subdirectory start location is by design, not a bug.

[Zanop]

Mine wont get into directories, it always shows the first directory listing with the categories no mather what I click. The top of the screen shows the current directory, it descends to whatever I select while the list remains always the same. Deleting the ftp.(null) file does not change anything, it just recreates is and always lists first dir. Permissions on the dir are right, owner 'pi'.

I have noticed the ftp.(null) and thought thats the problem. Built from source, any ideas?

[rhaleblian]

Hi @Zanop , hmm i was recently wondering whether this was ok or not in mainline so i could decide what to do with my fork. When i can, i'll build from the same source you did; if it happens to me too i might have a fix for it after all.

[Zanop]

Hi @rhaleblian, I have submitted a fix, check out my pull request.

[dabonetn]

I'll try to get to these soon, sorry, been tied up with real life lately.

[rhaleblian]

Me too, i might have time tonight.

[rhaleblian]

#10
works, see comments.