Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio level control? #6

Open
rhaleblian opened this issue Jun 23, 2018 · 2 comments
Open

Audio level control? #6

rhaleblian opened this issue Jun 23, 2018 · 2 comments

Comments

@rhaleblian
Copy link

I didn't see any. I'll blow my speakers out at some point... 🔈 !!!

@rhaleblian
Copy link
Author

rhaleblian commented Jun 24, 2018

There's normalization code that's defeated. It sets the volume based on SDL_MIX_MAXVOLUME.
SD_VOLUME is set to 50% but isn't used anywhere.
I would opt for using

void SDL_MixAudio(Uint8*       dst,
                  const Uint8* src,
                  Uint32       len,
                  int          volume)

which would require changing the audio callback to pass buffers as bytes, not shorts.

@rhaleblian
Copy link
Author

https://github.com/rhaleblian/linapple-pie/tree/volume
re-exposes "Speaker Volume" in the conf. This code stopped exiting cleanly though (double-free).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant