Add syslog v7 support #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back the syslog crate was updated to v7. This PR adds compatibility with this new version in fern. Also added `.vscode` to the `.gitignore` and fixed a comment where it mentioned `syslog-4` where it should have been `syslog-6` Signed-off-by: BlackDex <[email protected]>
|
I have also tested this code with Vaultwarden, and it works just fine. |
|
@daboross, please let me know if any adjustments need to be made. |
daboross
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Looks mostly good! Thanks for making this.
There's only one adjustment I'd ask for - removing the # default = comment & following extra blank line from Cargo.toml.
With that fixed, I'd be happy to merge this & release it in maybe a week or so with some other changes I have in mind for fern 0.7.1.
Signed-off-by: BlackDex <[email protected]>
|
Cool. Thanks for the quick reply :). |
|
Any chance of trigger a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while back the syslog crate was updated to v7.
This PR adds compatibility with this new version in fern.
Also added
.vscodeto the.gitignoreand fixed a comment where it mentionedsyslog-4where it should have beensyslog-6