From 889edef16ee6fce2af563718b1cb2f4e1bc73db6 Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Tue, 8 Oct 2024 14:15:32 +0200 Subject: [PATCH 1/4] [TEST] modify chromium version --- .github/workflows/codeception.yml | 2 -- .github/workflows/php-stan.yml | 4 ++++ UPGRADE.md | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml index d71436bf..738241cb 100644 --- a/.github/workflows/codeception.yml +++ b/.github/workflows/codeception.yml @@ -46,8 +46,6 @@ jobs: template_tag: v11.0.0 steps: - uses: nanasess/setup-chromedriver@v2 - with: - chromedriver-version: '127.0.6533.119' - uses: actions/checkout@v4 with: path: lib/test-bundle diff --git a/.github/workflows/php-stan.yml b/.github/workflows/php-stan.yml index 6f42d8e3..a5a7feef 100644 --- a/.github/workflows/php-stan.yml +++ b/.github/workflows/php-stan.yml @@ -110,6 +110,10 @@ jobs: run: | bin/console assets:install public --relative --symlink + - name: Validate Container + run: | + bin/console lint:container + - name: Php Stan run: | bin/console cache:warmup --env=test diff --git a/UPGRADE.md b/UPGRADE.md index 2a2746f5..7e54c68f 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -1,5 +1,8 @@ # Upgrade Notes +## 5.1.3 +- **[BUGFIX]** Fix DoubleOptInType Service Definition [@dpfaffenbauer](https://github.com/dachcom-digital/pimcore-formbuilder/pull/483) + ## 5.1.2 - **[IMPROVEMENT]** [File Upload] Add Deeplink Option to file upload field [#475](https://github.com/dachcom-digital/pimcore-formbuilder/issues/475) - **[BUGFIX]** [Double-Opt-In] Remove unique index, allow admin to define unique data behavior [#477](https://github.com/dachcom-digital/pimcore-formbuilder/issues/477) From 22a937d112447dcb7668bc7e640c68f430b04771 Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Tue, 8 Oct 2024 14:24:28 +0200 Subject: [PATCH 2/4] [TEST] modify chromium version --- .github/workflows/codeception.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml index 738241cb..d27c8f69 100644 --- a/.github/workflows/codeception.yml +++ b/.github/workflows/codeception.yml @@ -100,7 +100,7 @@ jobs: - name: Setup Chromium run: | export DISPLAY=:99 - chromedriver --url-base=/wd/hub & + chromedriver --url-base=/wd/hub --port=9515 & sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # optional - name: Start Symfony Server From a5b225394bc93e39124cd355c6ccf7a2df0e014e Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Tue, 8 Oct 2024 14:50:36 +0200 Subject: [PATCH 3/4] [TEST] modify chromium version --- .github/workflows/codeception.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeception.yml b/.github/workflows/codeception.yml index d27c8f69..233e0780 100644 --- a/.github/workflows/codeception.yml +++ b/.github/workflows/codeception.yml @@ -101,7 +101,7 @@ jobs: run: | export DISPLAY=:99 chromedriver --url-base=/wd/hub --port=9515 & - sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # optional + sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & - name: Start Symfony Server run: | From 4682b59247523eaed3d9eb391acdb4abac08f776 Mon Sep 17 00:00:00 2001 From: Stefan Hagspiel Date: Tue, 8 Oct 2024 14:59:08 +0200 Subject: [PATCH 4/4] [TEST] modify chromium version --- tests/_envs/github.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/_envs/github.yml b/tests/_envs/github.yml index 0cd67170..99f9fbe0 100644 --- a/tests/_envs/github.yml +++ b/tests/_envs/github.yml @@ -5,6 +5,7 @@ modules: port: 9515 restart: true wait: 1 + window_size: 1280x1024 capabilities: 'goog:chromeOptions': args: ['--no-sandbox', '--disable-extensions', '--headless', '--disable-gpu', '--disable-dev-shm-usage', '--window-size=1280,1024']