Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to pimcore 5.6.0 #81

Closed
iventura opened this issue Jan 11, 2019 · 4 comments
Closed

update to pimcore 5.6.0 #81

iventura opened this issue Jan 11, 2019 · 4 comments
Labels
Milestone

Comments

@iventura
Copy link

Q A
Bug report? yes

by the update to pimcore 5.6.0 follow error appears:

Error: Class MembersBundle\CoreExtension\GroupMultiselect contains 2 abstra
ct methods and must therefore be declared abstract or implement the remaini
ng methods (Pimcore\Model\DataObject\ClassDefinition\Data\Relations\Abstrac
tRelations::loadData, Pimcore\Model\DataObject\ClassDefinition\Data\Relatio
ns\AbstractRelations::prepareDataForPersistence)

Looks like too more abstract classes were added to Pimcore\Model\DataObject\ClassDefinition\Data\Relations\Abstrac
tRelations and they have to be implemented in the MembersBundle\CoreExtension\GroupMultiselect

lorextera added a commit to lorextera/pimcore-members that referenced this issue Jan 11, 2019
solverat pushed a commit that referenced this issue Jan 13, 2019
* fix - the filename fallback must only contain ASCII characters

* #81 fix for compatibility with pimcore 5.6.0
@solverat
Copy link
Member

Partially fixed. Installer still not working though. This will be fixed with the tests pr. (#78).

@solverat solverat added the task label Jan 13, 2019
@solverat solverat added this to the 2.3.0 milestone Jan 13, 2019
@iventura
Copy link
Author

Hi guys, and thank you a lot for the fix. I tried it already and have a new exception in the prepareDataForPersistence function, which calls getDataFromResource with the array of objects. The exception happens by the line GroupMultiselect.php:169: if ($element['type'] == 'object'):
Cannot use object of type Pimcore\Model\DataObject\MembersGroup as array

May be it will help you.

With the best regards,
Ivan

@solverat
Copy link
Member

yes, i'm working on it.

@solverat
Copy link
Member

this should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants