Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: docker build workflow upgrade #280

Open
hero-intelligent opened this issue Sep 17, 2023 · 12 comments
Open

ci: docker build workflow upgrade #280

hero-intelligent opened this issue Sep 17, 2023 · 12 comments
Assignees
Labels

Comments

@hero-intelligent
Copy link
Contributor

Basically done. Please review my code first. Now there is a big commented block which keepsalmost all the working process. repo: hero-intelligent/daed

Details tomorrow.

@dae-prow
Copy link
Contributor

dae-prow bot commented Sep 17, 2023

Thanks for opening this issue!

@piyoki
Copy link
Contributor

piyoki commented Sep 17, 2023

@hero-intelligent cc @kuni_sh

@hero-intelligent
Copy link
Contributor Author

If you are satisfied so far, I will open a pr, and modify again.

Please don't worry about those failures in my actions, nor the big chunk of commented code. As I have no redhat account, i have to comment out this part. My dockerhub username is different from that of github, so, our code cannot be the same.

Now my code should work in this repo. But we need cooperation this time.

The docker build process takes about 48 minutes, which is very long, so I have to treasure each test.

Full change log tomorrow.

@hero-intelligent
Copy link
Contributor Author

@hero-intelligent
Copy link
Contributor Author

hero-intelligent commented Sep 18, 2023

@yqlbu @kunish These will be the final change log when opening pull request

Change Log

ci(docker): docker build once and push to multiple repos
ci(docker): docker build and push with tags
ci(docker): come back arm64 platform support (Experimental)
ci(docker): publish dockerhub image
ci(docker): action version upgrade
ci(docker): multiple action trigger
ci(docker): build with tag on dashboard

Others

A dockerhub account that has write access to daeuniverse/daed is needed! @mzz2017

Now the release and prerelease trigger has working perfectly, and building process works just fine.

Since my dockerhub username is different from github, I need to modify my code a little bit so that I can test if it can successfully push to both ghcr and dockerhub WITH TAGS.

dockerhub repo: huangqizigailee/daed

You can test if this image works just fine so far.

See you 48 minutes later.

@mzz2017
Copy link
Contributor

mzz2017 commented Sep 18, 2023

LGTM. I can provide the access to dockerhub account daeuniverse.

@hero-intelligent
Copy link
Contributor Author

hero-intelligent commented Sep 18, 2023

the result looks something like this: https://hub.docker.com/r/huangqizigailee/daed-test

@hero-intelligent
Copy link
Contributor Author

I'll open a pull request after the secrets ${{ github.DOCKERHUB_USERNAME }} and ${{ github.DOCKERHUB_PASS }} are ready. @mzz2017 please reply when ready. Apologies that I didn't follow your commit naming guidelines this time. As for testing on pushing, we need to cooperate.

@mzz2017
Copy link
Contributor

mzz2017 commented Sep 20, 2023

@hero-intelligent You mean that I should give the secret name "github.DOCKERHUB_USERNAME" instead of "DOCKERHUB_USERNAME"?

@mzz2017
Copy link
Contributor

mzz2017 commented Sep 20, 2023

@hero-intelligent BTW, can you use Access Tokens in docker hub?

@mzz2017
Copy link
Contributor

mzz2017 commented Sep 20, 2023

image

https://github.com/daeuniverse/dae/blob/main/.github/workflows/docker.yml#L48

Looks yes.


I've added above two secrets.

@hero-intelligent
Copy link
Contributor Author

Ready for review. @kunish @mzz2017 @yqlbu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants