-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: docker build workflow upgrade #280
Comments
Thanks for opening this issue! |
@hero-intelligent cc @kuni_sh |
If you are satisfied so far, I will open a pr, and modify again. Please don't worry about those failures in my actions, nor the big chunk of commented code. As I have no redhat account, i have to comment out this part. My dockerhub username is different from that of github, so, our code cannot be the same. Now my code should work in this repo. But we need cooperation this time. The docker build process takes about 48 minutes, which is very long, so I have to treasure each test. Full change log tomorrow. |
@yqlbu @kunish These will be the final change log when opening pull request Change Logci(docker): docker build once and push to multiple repos OthersA dockerhub account that has write access to Now the release and prerelease trigger has working perfectly, and building process works just fine. Since my dockerhub username is different from github, I need to modify my code a little bit so that I can test if it can successfully push to both ghcr and dockerhub WITH TAGS. dockerhub repo: huangqizigailee/daed You can test if this image works just fine so far. See you 48 minutes later. |
LGTM. I can provide the access to dockerhub account daeuniverse. |
the result looks something like this: https://hub.docker.com/r/huangqizigailee/daed-test |
I'll open a pull request after the secrets |
@hero-intelligent You mean that I should give the secret name "github.DOCKERHUB_USERNAME" instead of "DOCKERHUB_USERNAME"? |
@hero-intelligent BTW, can you use |
https://github.com/daeuniverse/dae/blob/main/.github/workflows/docker.yml#L48 Looks yes. I've added above two secrets. |
Basically done. Please review my code first. Now there is a big commented block which keepsalmost all the working process. repo: hero-intelligent/daed
Details tomorrow.
The text was updated successfully, but these errors were encountered: