Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBORFactory type hints are used but that class is not imported #111

Open
lvh opened this issue Apr 1, 2017 · 1 comment
Open

CBORFactory type hints are used but that class is not imported #111

lvh opened this issue Apr 1, 2017 · 1 comment

Comments

@lvh
Copy link

lvh commented Apr 1, 2017

cheshire.core has CBORFactory type hints but that class is not imported. I haven't verified this, but I think that means they silently fail unless someone has reflection warnings on.

This also makes it harder to use cheshire with any project that tries to use ProGuard to minimize resulting jars.

I'd personally be pretty happy if CBOR and SMILE dependencies were optional (Lambda -- don't ask), but that's probably a different ticket.

@dakrone
Copy link
Owner

dakrone commented Apr 4, 2017

Thanks for reporting this @lvh, I'll take a look at it.

I'd personally be pretty happy if CBOR and SMILE dependencies were optional

I think I agree with this, it'd be nice if they were optional also. Jackson already makes them optional, it's just a matter of making them optional in the Clojure code.

dakrone added a commit that referenced this issue Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants