Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: core.typed annotations #82

Open
lvh opened this issue Jul 7, 2015 · 4 comments
Open

feature: core.typed annotations #82

lvh opened this issue Jul 7, 2015 · 4 comments

Comments

@lvh
Copy link

lvh commented Jul 7, 2015

Would this be welcomed if I started contributing them?

@michaelklishin
Copy link
Contributor

If this will make Cheshire depend on core.typed, then I'd vote against it. If this can be made entirely optional, why not.

@dakrone
Copy link
Owner

dakrone commented Aug 13, 2015

I agree with Michael, if optional, yeah, if it added the dependency then probably not.

@lvh
Copy link
Author

lvh commented Aug 14, 2015

Would it be okay if it's a dev-time only dependency? core.typed is just a compile-time checker; it shouldn't show up e.g. production uberjars.

@dakrone
Copy link
Owner

dakrone commented Aug 15, 2015

@lvh I think a dev-time only dep is okay with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants