Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse-stream rejects types that JsonFactory.createParser accepts #98

Open
pcarlisle opened this issue Mar 1, 2016 · 2 comments · May be fixed by #176
Open

parse-stream rejects types that JsonFactory.createParser accepts #98

pcarlisle opened this issue Mar 1, 2016 · 2 comments · May be fixed by #176

Comments

@pcarlisle
Copy link

Because of the type hinting, parse-stream requires a Reader to be passed in. The createParser method in Jackson will accept an InputStream, and it would be nice if it were possible to pass that in directly without having to create a Reader. The jackson docs at http://wiki.fasterxml.com/JacksonBestPracticesPerformance strongly suggest not creating a Reader before calling createParser if you already have an InputStream. If you create a reader then you don't get the encoding detection that Jackson has.

@dakrone
Copy link
Owner

dakrone commented Mar 1, 2016

@pcarlisle thanks for pointing this out to me, I'll take a look!

@dakrone
Copy link
Owner

dakrone commented Apr 10, 2016

I went down the path of trying to make this and other changes suggested in the best practices, but it breaks a lot of things. This will take longer to implement than I had expected

@nilern nilern linked a pull request Mar 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants