Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout engine YAML config #1035

Merged
merged 34 commits into from
Oct 5, 2024
Merged

Layout engine YAML config #1035

merged 34 commits into from
Oct 5, 2024

Conversation

dalyIsaac
Copy link
Owner

@dalyIsaac dalyIsaac commented Sep 26, 2024

  • Added a mechanism to specify the layout engines for all workspaces.
  • Added config options to customize each layout engine.
  • Renamed filter_type and router_type to type.
  • Cursory docs.

@dalyIsaac dalyIsaac added enhancement New feature or request core Whim yaml/json config The alternative to using C# scripts labels Sep 26, 2024
@dalyIsaac dalyIsaac linked an issue Sep 26, 2024 that may be closed by this pull request
16 tasks
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 92.80576% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (0000b43) to head (ded5a46).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Whim.Yaml/YamlLayoutEngineLoader.cs 95.41% 4 Missing and 1 partial ⚠️
src/Whim.Yaml/YamlLoader.cs 20.00% 2 Missing and 2 partials ⚠️
src/Whim.Yaml/YamlLoaderUtils.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   80.54%   80.73%   +0.18%     
==========================================
  Files         280      281       +1     
  Lines       11989    12123     +134     
  Branches     1374     1390      +16     
==========================================
+ Hits         9657     9787     +130     
- Misses       2158     2161       +3     
- Partials      174      175       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalyIsaac dalyIsaac changed the base branch from main to slicelayoutengine-fixes September 27, 2024 14:27
Base automatically changed from slicelayoutengine-fixes to main October 1, 2024 12:59
@dalyIsaac dalyIsaac marked this pull request as ready for review October 5, 2024 05:38
@dalyIsaac dalyIsaac merged commit 52e2748 into main Oct 5, 2024
10 checks passed
@dalyIsaac dalyIsaac deleted the 1032-workspaces-yaml-config branch October 5, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Whim enhancement New feature or request yaml/json config The alternative to using C# scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout engines YAML config
1 participant