Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC Charging with Leaf PDM not functioning because 0x1D4 is not being sent in charge mode #91

Open
Romukeisari opened this issue Apr 29, 2024 · 6 comments

Comments

@Romukeisari
Copy link

PDM goes to fail-safe, because 1D4 is not being sent in charge mode.

Add 1D4 to PDM code, so it gets sent when in charge mode.
I have this working in my fork https://github.com/Romukeisari/Stm32-vcu-LeafLBC/blob/master/src/NissanPDM.cpp
Background: https://openinverter.org/forum/viewtopic.php?p=70232#p70232

@damienmaguire
Copy link
Owner

Thanks. Will review.

@Tom-evnut
Copy link
Contributor

0x1D4 is sent for the inverter also, however in the STM32_vcu

This task is only called in a if function when the opmode is RUN "402 selectedInverter->Task10Ms();"

Tom-evnut added a commit to Tom-evnut/Stm32-vcu that referenced this issue May 1, 2024
damienmaguire#91

Cleaner implementation

Added 1D4 into PDM 10ms task and only send when in charge, only time we do not have it sent by the Inverter 10ms task
@Tom-evnut
Copy link
Contributor

@Romukeisari
Copy link
Author

Create a "cleaner application" https://github.com/Tom-evnut/Stm32-vcu/tree/2.17A-Leaf-PDM-potential-fix

If I may suggest, add a parameter read to check that also the Leaf inverter is there, otherwise this needs to be sent in all use cases so PDM doesn't go to fail-safe? Although fail-safe clears when powered off, wouldn't it be a preferred method of control to avoid the components going into fail-safe in all use cases?

@Tom-evnut
Copy link
Contributor

If I may suggest, add a parameter read to check that also the Leaf inverter is there

You would not use the PDM without the inverter really. Once testing is completed can review it and add it it in easily.

@Tom-evnut
Copy link
Contributor

@damienmaguire once you prove charging is working on your setup feel free to close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants