From 620cd3e1043461c1f7b0751d62fdd54dbd931675 Mon Sep 17 00:00:00 2001 From: Lukas W Date: Sat, 4 Nov 2023 17:40:08 +0100 Subject: [PATCH 1/2] CI: Update to macOS 12 Homebrew doesn't provide bottles for macOS 11 anymore, causing dependencies to be compiled in CI which takes approximately 173 years. Therefore, upgrade to macOS 12 and - remove DEVELOPER_DIR environment variable which caused problems but its removal doesn't appear to break anything - upgrade npm because versions before 10.2.2 use Python's distutils package which was removed in Python 12. See - https://github.com/npm/cli/pull/6937 - https://github.com/nodejs/node-gyp/issues/2869 --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e8cec886705..2a5b6655878 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -69,7 +69,7 @@ jobs: CCACHE_MAXSIZE: 500M macos: name: macos - runs-on: macos-11 + runs-on: macos-12 env: CMAKE_OPTS: >- -DUSE_WERROR=ON @@ -78,7 +78,6 @@ jobs: CCACHE_MAXSIZE: 0 CCACHE_NOCOMPRESS: 1 MAKEFLAGS: -j3 - DEVELOPER_DIR: /Applications/Xcode_11.7.app/Contents/Developer steps: - name: Check out uses: actions/checkout@v3 @@ -105,6 +104,7 @@ jobs: - name: Install dependencies run: | brew bundle install --verbose + npm update -g npm npm install --location=global appdmg env: HOMEBREW_NO_AUTO_UPDATE: 1 From f6a1f25cf9219a0b6ea9d16b051f3da7f2f6fbc3 Mon Sep 17 00:00:00 2001 From: Lukas W Date: Sun, 5 Nov 2023 12:27:53 +0100 Subject: [PATCH 2/2] CI: Use lowest Xcode version available For compatibility with older macOS versions, see discussion at https://github.com/LMMS/lmms/pull/6960#discussion_r1382432764 --- .github/workflows/build.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2a5b6655878..5fe1ec7bf72 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -78,6 +78,7 @@ jobs: CCACHE_MAXSIZE: 0 CCACHE_NOCOMPRESS: 1 MAKEFLAGS: -j3 + DEVELOPER_DIR: /Applications/Xcode_13.1.app/Contents/Developer steps: - name: Check out uses: actions/checkout@v3