Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the code-base to TypeScript #57

Open
dance2die opened this issue Feb 2, 2019 · 3 comments
Open

Convert the code-base to TypeScript #57

dance2die opened this issue Feb 2, 2019 · 3 comments
Assignees
@dance2die
Labels
Administrative Administrative tasks

Comments

@dance2die
Copy link
Owner

Migrate to TypeScript.

TypeScript is bae 💖.
@dance2die dance2die added the Administrative Administrative tasks label Feb 2, 2019
@dance2die dance2die self-assigned this Feb 2, 2019
@claudiopedrom
Copy link

Hi @dance2die are you currently working on this? 😌

@dance2die
Copy link
Owner Author

Hiya, @claudiopedrom.

Nope. I haven't worked on this library for awhile.
If you could migrate & PR, it'd be nice 😉

@perry-mitchell
Copy link

perry-mitchell commented Feb 10, 2021 •
edited
Loading

@dance2die I'd like to have a go of converting.. I'll submit a PR shortly.

EDIT: On a similiar note, I'd propose to remove the class definition in the index in favour of exporting functions - Classes don't transpile well and include a bit of bloat for compatibility. As I'm not sure of your target compatibility, I would recommend using just exported functions as it's simpler for your users to consume. This would necessitate a major version bump in my opinion - but I'd be interested to hear what you think about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dance2die dance2die

Labels
Administrative Administrative tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@perry-mitchell @claudiopedrom @dance2die