Ignore unclosed connection resource warning from VCR #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locally (vcr 5.1.0) it causes tests to fail, possibly masking another issue ref: #1332
yarikoptic
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1333 +/- ##
==========================================
- Coverage 88.81% 88.78% -0.03%
==========================================
Files 76 76
Lines 10216 10216
==========================================
- Hits 9073 9070 -3
- Misses 1143 1146 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
type checking also happens in #1334 where I am fixing up linters -- the codespell needs fresh fixes |
|
ok, it doesn't resolve #1332 anyhow. I will proceed with it anyways to simplify troubleshooting |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
locally (vcr 5.1.0) it causes tests to fail, possibly masking another issue ref: #1332 which I otherwise fail to reproduce locally