Disallow hdmf 3.14.4, make organize to not parallelize for a single file, log information about all exceptions while reading metadata for organize #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joblib does not setup automagically some kind of logging for Parallel. Filed dedicated to possibly see it implemented - #1495 For the sake of current use case (e.g. troubleshooting #1494) it should largely suffice to return and log information about exception which was raised while loading metadata. This is what is done in this PR and while using buggy hdmf we do get nice logging in the log file at DEBUG level. No attempts were made to reduce possibly a flood of duplicate log messages since per file metadata would have unique values
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1496 +/- ##
==========================================
+ Coverage 88.55% 88.63% +0.07%
==========================================
Files 77 77
Lines 10568 10572 +4
==========================================
+ Hits 9359 9371 +12
+ Misses 1209 1201 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
asmacdo
reviewed
Sep 5, 2024
|
well, |
|
well, 3.12 failed with since remote -- may be some connection? but it cannot relate to the changes here |
…used var Co-authored-by: Austin Macdonald <[email protected]>
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual commits have more information in their description.
Overall it
I have bundled all the fixes etc so we could return back our CI to green (happen there is more to fix) and release!