Refactor some download code for readability + ensure that we checksum resumed downloads #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yarikoptic
commented
Nov 23, 2024
yarikoptic
commented
- Closes Add checksumming of the full download in case of retries #1528
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1097
to
+1103
| # if is_access_denied(exc) or attempt >= 2: | ||
| # raise |
Check notice
Code scanning / CodeQL
Commented-out code Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 88.44% 88.52% +0.07%
==========================================
Files 78 78
Lines 10691 10713 +22
==========================================
+ Hits 9456 9484 +28
+ Misses 1235 1229 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jwodder
approved these changes
Nov 25, 2024
…tempts_allowed no functionality changes should be done. Also removed some stale TODO comments -- DownloadDirectory already downloads into a file with ".dandidownload" instead of original filename. And we do report progress. ETA should be estimated outside IMHO.
yarikoptic
force-pushed
the
enh-digest
branch
from
345e6e0
to
7efa0b2
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.