Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NotImplementedError to allow for uploading Zarr assets to embargoed Dandisets #1540

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Remove NotImplementedError to allow for uploading Zarr assets to embargoed Dandisets #1540

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
445c898
Remove `NotImplementedError` to allow for uploading Zarr assets to em…
kabilar Nov 25, 2024
07c840b
Remove import
kabilar Nov 25, 2024
c56665c
RF + ENH: parametrize test_upload_sync_zarr to test against both emba…
yarikoptic Nov 26, 2024
1deba35
RF: make any "new_dandiset" fixture work together with @sweep_embargo
yarikoptic Nov 27, 2024
60ccca2
ENH: Mark one more dataset testing on simpler files on embargo"ed ver…
yarikoptic Nov 27, 2024
2a1c5ed
Add type annotation for mocker
yarikoptic Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dandi/files/zarr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,12 +297,6 @@ def iter_upload(
``"done"`` and an ``"asset"`` key containing the resulting
`RemoteAsset`.
"""
# So that older clients don't get away with doing the wrong thing once
# Zarr upload to embargoed Dandisets is implemented in the API:
if dandiset.embargo_status is EmbargoStatus.EMBARGOED:
kabilar marked this conversation as resolved.
Show resolved Hide resolved
raise NotImplementedError(
"Uploading Zarr assets to embargoed Dandisets is currently not implemented"
)
asset_path = metadata.setdefault("path", self.path)
client = dandiset.client
lgr.debug("%s: Producing asset", asset_path)
Expand Down
Loading