Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hdmf-zarr git repo into our dev build testing #1542

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

yarikoptic
Copy link
Member

This should resolve our current failure due to No module named hdmf.array

Closes #1541
Ref: hdmf-dev/hdmf-zarr#235

attn @kabilar -- apparently I have missed @rly 's response there pointing to an obvious solution ;-), although ATM we do not use/rely on hdmf-zarr functionality directly AFAIK.

This should resolve our current failure due to No module named hdmf.array

Closes #1541
Ref: hdmf-dev/hdmf-zarr#235
@yarikoptic yarikoptic added the tests Add or improve existing tests label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (2210320) to head (d62bcd9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1542      +/-   ##
==========================================
- Coverage   88.46%   88.45%   -0.01%     
==========================================
  Files          78       78              
  Lines       10718    10718              
==========================================
- Hits         9482     9481       -1     
- Misses       1236     1237       +1     
Flag Coverage Δ
unittests 88.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

nfs fail is unrelated, dev-deps is green! let's proceed!

_____________________ test_organize_nwb_test_data[-1-dry] ______________________
dandi/tests/test_organize.py:174: in test_organize_nwb_test_data
    r = CliRunner().invoke(organize, cmd)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/click/testing.py:408: in invoke
    return_value = cli.main(args=args or (), prog_name=prog_name, **extra)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/click/core.py:1078: in main
    rv = self.invoke(ctx)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/click/core.py:1434: in invoke
    return ctx.invoke(self.callback, **ctx.params)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/click/core.py:783: in invoke
    return __callback(*args, **kwargs)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/click/decorators.py:45: in new_func
    return f(get_current_context().obj, *args, **kwargs)
dandi/cli/base.py:126: in wrapper
    return f(*args, **kwargs)
dandi/cli/cmd_organize.py:112: in organize
    organize(
dandi/organize.py:870: in organize
    Parallel(n_jobs=jobs, verbose=10)(
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/joblib/parallel.py:2007: in __call__
    return output if self.return_generator else list(output)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/joblib/parallel.py:1650: in _get_outputs
    yield from self._retrieve()
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/joblib/parallel.py:1762: in _retrieve
    time.sleep(0.01)
E   Failed: Timeout >300.0s

During handling of the above exception, another exception occurred:
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/_pytest/runner.py:341: in from_call
    result: TResult | None = func()
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/_pytest/runner.py:242: in <lambda>
    lambda: runtest_hook(item=item, **kwds), when=when, reraise=reraise
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pluggy/_hooks.py:513: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/_pytest/threadexception.py:92: in pytest_runtest_call
    yield from thread_exception_runtest_hook()
/opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/site-packages/_pytest/threadexception.py:82: in thread_exception_runtest_hook
    warnings.warn(pytest.PytestUnhandledThreadExceptionWarning(msg))

@yarikoptic yarikoptic merged commit 8326a83 into master Nov 27, 2024
23 of 25 checks passed
@yarikoptic yarikoptic deleted the bf-dev-build branch November 27, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures of No module named 'hdmf.array'
1 participant